Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1444 resolve linked content blocks in assets enhance bt dependencies with it #1452

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Jul 15, 2024

PR details

What changes did you make? (Give an overview)

Further details (optional)

...

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (TODO)

…-references during actual retrieve; also refactoring
@JoernBerkefeld JoernBerkefeld added this to the 7.1.0 milestone Jul 15, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Jul 15, 2024
@github-actions github-actions bot added the enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" label Jul 15, 2024
Copy link

github-actions bot commented Jul 15, 2024

Coverage Report

Commit:7ec3fe4
Base: develop@fbcf046

Type Base This PR
Total Statements Coverage  69.91%  70.25%  (+0.34%)
Total Branches Coverage  69.08%  69.17%  (+0.09%)
Total Functions Coverage  82.04%  82.3%  (+0.26%)
Total Lines Coverage  69.91%  70.25%  (+0.34%)
Details (changed files):
File Statements Branches Functions Lines
lib/Builder.js  86.59%  53.12%  100%  86.59%
lib/metadataTypes/Asset.js  73.43%  62.59%  86.36%  73.43%
lib/metadataTypes/Automation.js  80.56%  63.8%  94.44%  80.56%
lib/metadataTypes/MetadataType.js  82.84%  80.67%  76.62%  82.84%
lib/util/replaceContentBlockReference.js  95.66%  86.84%  100%  95.66%
lib/util/util.js  84.52%  76.96%  92.5%  84.52%

@JoernBerkefeld
Copy link
Contributor Author

resolving asset keys & improving caching done now.
todo:

  • look through the new r__asset_keys when finding dependencies

@JoernBerkefeld JoernBerkefeld merged commit fbe2201 into develop Jul 17, 2024
7 of 9 checks passed
@JoernBerkefeld JoernBerkefeld deleted the feature/1444-resolve-linked-content-blocks-in-assets-enhance-bt-dependencies-with-it branch July 17, 2024 15:35
@JoernBerkefeld JoernBerkefeld mentioned this pull request Jul 17, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] resolve linked content blocks in assets & enhance bt --dependencies with it
1 participant