Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Colours and contrast #188

Merged
merged 34 commits into from
Dec 17, 2019
Merged

Colours and contrast #188

merged 34 commits into from
Dec 17, 2019

Conversation

AndreasMoesch
Copy link
Collaborator

This pull requrest replaces @jmuheim’s original pull request (#152).

Since @jmuheim isn’t active in the project anymore we decided during hackday 9 that @AndreasMoesch forks this content, applies his review and then resubmits it as a new pull request.

jmuheim and others added 16 commits August 12, 2018 15:23
@AndreasMoesch AndreasMoesch self-assigned this Dec 26, 2018
@AndreasMoesch AndreasMoesch mentioned this pull request Dec 26, 2018
Closed
@AndreasMoesch
Copy link
Collaborator Author

AndreasMoesch commented Dec 26, 2018 •
edited
Loading

@backflip Sorry, I don’t know why the checks fail. The logs point to some issue with gulp. I already encountered this problem when building the site locally. I worked around it for myself by changing the gulp dependency in the package.json file ("gulp": "^4.0.0", instead of "gulp": "github:gulpjs/gulp#4.0") but this change was never commited.

@backflip backflip mentioned this pull request Dec 28, 2018
Merged
@backflip
Copy link
Collaborator

@AndreasMoesch, thanks for the pointer, I have openend #189
What is the current merge convention? Do I wait for a specific person to review and approve it?

@AndreasMoesch
Copy link
Collaborator Author

@backflip Thanks! Regarding the merge convention: We have a defined process for content-related merge requests but this doesn’t apply to bug fixes.

So, in the absence of a defined process I’ll add my review to #189. Seeing that this is issue prevents content-related reviews (which need a the deployed version) I think this has to be merged before release 1.1.

@AndreasMoesch
Updates gulp dependency in package.json
11a282f 
This is necessary for the build process to succeed. The build process should succeed so that the changes can be reviewed.
@AndreasMoesch
Copy link
Collaborator Author

I pushed the updated package.json file (same change as in #189) so that we have a preview build for this pull request that can be used for the review.

@gurix
Copy link
Collaborator

gurix commented Jan 10, 2019

Cool thanks. Do you think we could send it to Access4All for a review? If yes, drop a mail to @retoinniger.

@AndreasMoesch
Adds first set of content correcitons
fd40d06 
Changes done on Hackday Access4all#12 together with Josh
@backflip backflip changed the base branch from releases/1.1 to master December 13, 2019 08:35
@AndreasMoesch
Copy link
Collaborator Author

@jmuheim I have taken care of all the open points from the review. Assigning to you for next steps.

@jmuheim jmuheim merged commit 5a44081 into Access4all:master Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmuheim jmuheim jmuheim left review comments

@gurix gurix gurix left review comments

Assignees

@jmuheim jmuheim

Labels
scope: content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AndreasMoesch @backflip @gurix @jmuheim