Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer - Uninstall without admin and should check if installed already #106

Closed
4 tasks done
willwade opened this issue Jul 9, 2022 · 1 comment
Closed
4 tasks done

Comments

@willwade
Copy link
Contributor

willwade commented Jul 9, 2022

  • Need to integrate this kind of logic - https://nsis.sourceforge.io/Auto-uninstall_old_before_installing_new - basically if you have it installed already and try and install it seems to work but it won't because the service is running and then files are being accessed. It basically makes a right mess
  • Uninstalling is not set to run as admin. I dont get why - see http://forums.winamp.com/showthread.php?p=3221719#post3221719 . Because of this it never uninstalls - unless the user manually elevates the uninstall package
  • As a bonus it would be nice if the correct shortcuts are made on Windows 10/11. You dont see it in the app list reliably. No idea why
  • uninstaller not being recognised in add/remove apps. Or at least I don't think so
@willwade
Copy link
Contributor Author

Just realised our build script is super hacky. We should be doing this rather than copying all the files into one: https://www.zacoding.com/en/post/pyinstaller-create-multiple-executables/

willwade added a commit that referenced this issue Jul 11, 2022
willwade added a commit that referenced this issue Jul 11, 2022
Fixes for #106 - yet to improve the pyinstaller mess but thats ok for now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant