Revised GridSets & docs #147
Conversation
quaxalber
changed the title
There was a problem hiding this comment.
Added footnotes and made some changes for better clarity and accuracy. Please let me know what you think and I will adapt for EN and DE docs accordingly
There was a problem hiding this comment.
This looks great - happy to merge when you are! Thanks a million
There was a problem hiding this comment.
This allows to easily run a daemon on Windows without RelayKeys hardware
There was a problem hiding this comment.
Great. I did try and tidy up all this non-essential testing code once to tidy up the repo but never managed it. I wonder about some kind of multi-batch script you call with flags. I don’t know. Adding more work than it needs maybe.
Makes sense the Xfrozen_modules=off thing
There was a problem hiding this comment.
I hear you. I reckon another tidying/refactoring pass would be time well spent since (inevitably) quite some technical debt has accumulated over time (long functions, repetitive code, deep nesting, ...) which makes it hard to follow along and make changes for someone new to the project. @willwade
|
Green lights for a merge from my side @willwade |
Adapted UK and US to the new layout. If you can please test and see if you spot any issues.