-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate out ROS dependencies, create second pip package #45
Conversation
* remove ros stuff from tests * rename Python package from dual_quaternions_ros to dual_quaternions
… for the ros conversions
…al quaternions in the first place' section to main readme
will probably want to add Python3 support for the standalone dual_quaternions package once this is in |
if someone just wants to install, they don't want to dig into the folders. Would be good to have the quick install instructions on the front page readme with links to more details if needed. |
Done. Was going to add after posting the package on pip but might as well set it up now. |
Opened a PR on rosdep: rosdep/#23261 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, this is far from the best review that I have ever done. I need to plug it in and test a bit more, but I don't see anything worrying. So should be good to go. I made comments for things that I would improve, but I don't think they are critical enough to not merge in.
Description
This breaks out the ROS conversion methods into a separate pip package while the underlying dual quaternion core code becomes ROS independent and purely pythonic. This means that non-ROS users can enjoy the power of dual quaternions as well.
This is a breaking change since the API changes. ROS projects using this repo should change their code from:
to:
The
dq
objects are still of class DualQuaternion and all methods can still be accessed through that. For other constructors, you will need tofrom dual_quaternions import DualQuaternion
.close #42
TODO