Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate out ROS dependencies, create second pip package #45

Merged
merged 16 commits into from
Dec 19, 2019
Merged

Conversation

Achllle
Copy link
Owner

@Achllle Achllle commented Dec 3, 2019

Description

This breaks out the ROS conversion methods into a separate pip package while the underlying dual quaternion core code becomes ROS independent and purely pythonic. This means that non-ROS users can enjoy the power of dual quaternions as well.

This is a breaking change since the API changes. ROS projects using this repo should change their code from:

from dual_quaternions_ros import DualQuaternion
dq = DualQuaternion.from_ros_pose(my_pose_msg)

to:

import dual_quaternions_ros
dq = dual_quaternions_ros.from_ros_pose(my_pose_msg)

The dq objects are still of class DualQuaternion and all methods can still be accessed through that. For other constructors, you will need to from dual_quaternions import DualQuaternion.

close #42

TODO

  • dependencies of ros pip package need to be updated to include geometry msgs and dual_quaternions

@Achllle Achllle self-assigned this Dec 3, 2019
@Achllle
Copy link
Owner Author

Achllle commented Dec 4, 2019

will probably want to add Python3 support for the standalone dual_quaternions package once this is in

@Achllle Achllle requested a review from mjsobrep December 4, 2019 21:20
@mjsobrep
Copy link
Collaborator

mjsobrep commented Dec 6, 2019

if someone just wants to install, they don't want to dig into the folders. Would be good to have the quick install instructions on the front page readme with links to more details if needed.

@Achllle
Copy link
Owner Author

Achllle commented Dec 6, 2019

Would be good to have the quick install instructions on the front page readme with links to more details if needed.

Done. Was going to add after posting the package on pip but might as well set it up now.

@Achllle
Copy link
Owner Author

Achllle commented Dec 9, 2019

Opened a PR on rosdep: rosdep/#23261

Copy link
Collaborator

@mjsobrep mjsobrep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this is far from the best review that I have ever done. I need to plug it in and test a bit more, but I don't see anything worrying. So should be good to go. I made comments for things that I would improve, but I don't think they are critical enough to not merge in.

dual_quaternions/README.rst Show resolved Hide resolved
dual_quaternions/dual_quaternions/__init__.py Show resolved Hide resolved
dual_quaternions/dual_quaternions/dual_quaternions.py Outdated Show resolved Hide resolved
dual_quaternions/setup.py Show resolved Hide resolved
README.rst Show resolved Hide resolved
@Achllle Achllle merged commit 09c7399 into master Dec 19, 2019
@Achllle Achllle deleted the iss42 branch December 19, 2019 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider splitting up in ROS package and pure python pkg
2 participants