Add logger name to default message #13
Conversation
| @@ -13,6 +13,9 @@ class StackDriverFormatStream extends Transform { | |||
| // tslint:disable-next-line:function-name | |||
| public _transform(chunk: any, _encoding: string, callback: (error?: Error | undefined, data?: any) => void) { | |||
| const obj = JSON.parse(chunk); | |||
| if (obj.name) { | |||
There was a problem hiding this comment.
Wow, why to choose such a generic prop name? I find it pretty common to use name in many objects that are logged directly.
@grissius whats your opinion on this?
There was a problem hiding this comment.
Actually, this is not something new. The name field is used for the logger name since the beginning, so this PR changes nothing for that matter.
But you are right, that this might be problematic. I will try to fix that in future PRs.
There was a problem hiding this comment.
Not event sure how to fix it. Know about it just from the discussion, PR comment and commented file. But I would not consider it a grave issue until it proves problematic.
There was a problem hiding this comment.
Might be in the logger property, but never in a message payload, this is new. So far there were only pkgVersion and level properties added, but never assumed anything from the payload it self.
Besides, is it really necessary to add it to the root of the message? You can add the loggerNameproperty to the payload, as you do with the pkgVersion for instance. It wouldnt be visible in the log message directly, but you can query Stackdriver for it 💡
Automatically put logger name before the message, when using default (stackdriver optimized) logger.
Before:
Some messageNow:
[Database] Some message