-
Notifications
You must be signed in to change notification settings - Fork 3
Conversation
cdb52c7
to
1bc3d75
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am now consfused with the differencies between moduleName
and the new loggerName
.
The purpose of the moduleName should've been to create a named module, so I could disable logging for a certain part (module) of the application. Whereas the loggerName propagates the given name to each of the logs.
If this is the case, I suggest to merge those two - use a name attribute (e.g. moduleName) and propagate this name to every log.
The situation before was following: if you passed a string to loggerFactory, named logger was created. Therefore its name was shown in all pretty logs and probably was present in non-pretty logs as After this change: If you pass a string to loggerFactory, named logger will be created. But it will no longer collide with objects with field But you are right - I could rename
I think this PR changes nothing about disabling loggers. |
And fix logger name for pretty loggers