Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promisify redis methods #43

Merged
merged 5 commits into from
Apr 30, 2019
Merged

Promisify redis methods #43

merged 5 commits into from
Apr 30, 2019

Conversation

rimiti
Copy link
Collaborator

@rimiti rimiti commented Apr 30, 2019

Purpose of this PR

This PR aims to auto promisify redis methods with bluebird to work with redis and ioredis package.

Regards,

@rimiti rimiti self-assigned this Apr 30, 2019
@codecov-io
Copy link

codecov-io commented Apr 30, 2019

Codecov Report

Merging #43 into master will increase coverage by 0.4%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #43     +/-   ##
=========================================
+ Coverage    89.5%   89.91%   +0.4%     
=========================================
  Files           8        8             
  Lines         343      347      +4     
  Branches       26       25      -1     
=========================================
+ Hits          307      312      +5     
+ Misses         34       33      -1     
  Partials        2        2
Impacted Files Coverage Δ
src/stores/redis.ts 86.84% <100%> (+4.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 511da38...d787c85. Read the comment docs.

@rimiti rimiti merged commit f82b932 into master Apr 30, 2019
@rimiti rimiti deleted the promisify-redis branch April 30, 2019 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants