Automatically add OPTIONS action #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… override OPTIONS from api blueprint.
|
Awesome thanks for the PR 👍 I'll have a look and make comments |
| @@ -69,6 +69,12 @@ By default a CORS header is sent, you can disable it with the --disableCORS swit | |||
|
|
|||
| `drakov -f "../com/foo/contracts/*.md" --disableCORS` | |||
|
|
|||
| ## Automatic response to OPTIONS requests | |||
There was a problem hiding this comment.
Huge thank you for updating the README 👍 🎱
|
Nice work 👍 A very well documented and tested PR 🎱 |
|
Bringing this again to the top, will review this again for possible release in 0.1.8 |
|
Merging |
yakovkhalinsky
added a commit
that referenced
this pull request
Jul 2, 2015
Automatically add OPTIONS action
|
Dont have time for that refactoring I promissed in #59 (comment) :-( |
|
@MartinNuc don't worry too much about it :) It's great to get this feature out to the people using Drakov. At this stage I'm ok with the code structure, which can evolve in the future 🎱 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating server based on API blueprint I wanted to use AngularJS against drakov as a basic mocking server.
First I allowed CORS headers (including HEADERS for POST requests):
After I would have to add OPTIONS action for every route so CORS prefight is successful.
Therefore I made slight changes to drakov to add OPTIONS action where it's missing. This is being turned on using flag
--autoOptions