Add known issues section #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mianculovici
approved these changes
Mar 25, 2024
clach04
requested changes
Mar 25, 2024
README.md
Outdated
Comment on lines
239
to
240
| Apache Superset issue [27427](https://github.com/apache/superset/issues/27427) | ||
| The Apache Superset SQL parser is able to recognize and handle row limiting clauses that use keywords **LIMIT** and **TOP** but does not handle the **FETCH FIRST** clause, which is used by some databases, including Ingres and PostgreSQL. If a **FETCH FIRST** clause is used in a SQL statement and the Superset config parameter **SQL_MAX_ROW** is set to a value > 0, the Superset parser appends a **LIMIT** clause to the SQL statement, making it syntactically invalid. This errant behavior can be seen when working with SQL statements and table metadata in Superset SQL Lab and may occur in other Superset operations as well. It is important to note that this is a problem with Apache Superset and not with the SQLAlchemy-Ingres connector. |
There was a problem hiding this comment.
This looks run on. The content is great! See https://github.com/ActianCorp/sqlalchemy-ingres/tree/hab6-add-known-issues#known-issues for what I mean.
Bare minimum change would be paragraph breaks:
- one after first line
- another one before the last line.
With those changes the markdown will be more clear. The text it self will be long in plain text so could benefit from some newlines but that's not a deal-breaker.
There was a problem hiding this comment.
Thank you for the suggestions! I added a few newlines. Hopefully it looks better now!
clach04
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Known Issues section to the Readme including information about Superset problem 27427