Allow missing appauthor to fall back to appname. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change provides a default value for
appauthorwhen on Windows.Rationale
1. For DRY
It is often the case where the "author" refers to the group that works on a project. Like with GitHub organizations, it is also often that the name of the group reuses the name of the project. Instead of repeating the "appname" in the arguments, this change makes this automatic.
2. For portability
Mac and Unix developers probably won't think about providing
appauthorsince it isn't used and isn't required. Meanwhile, a user running Windows will see an error. This fallback allows non-Windows developers to continue to ignore the unused argument, while enabling their project to work on Windows without any extra effort or waiting for a bug to be filed.