Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of having a commit ID for package operations is an error. #2827

Closed
wants to merge 1 commit into from

Conversation

mitchell-as
Copy link
Contributor

@mitchell-as mitchell-as commented Oct 17, 2023

TaskDX-2277 Local Orders: I should not be able to install a package if I don't have a commit

I didn't realize this issue was supposed to be blocked. Sorry :( Let me know if I should close this and redo it once the blocker issue lands. Feel free to incorporate it into the blocker issue too.

@mitchell-as
Copy link
Contributor Author

Test failures are not due to this PR. They are due to known, existing failures and the usual timeouts.

@mitchell-as mitchell-as marked this pull request as ready for review October 17, 2023 21:21
@mitchell-as
Copy link
Contributor Author

Closing in favor of #2841.

@mitchell-as mitchell-as removed the request for review from MDrakos October 23, 2023 15:37
@mitchell-as mitchell-as deleted the mitchell/dx-2277 branch October 23, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant