Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update error handling on revert (and pull) #2875

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Update error handling on revert (and pull) #2875

merged 1 commit into from
Nov 9, 2023

Conversation

MDrakos
Copy link
Member

@MDrakos MDrakos commented Nov 9, 2023 •
edited by github-actions bot
Loading

BugDX-2319 Error during `revert` command to a local commit and not auth execution

After discussing with Pete we will go forward with the improved error handling and follow up with the desired behavior once PB has had an opportunity to address it.

@github-actions github-actions bot changed the base branch from master to version/0-42-0-RC1 November 9, 2023 21:29
@MDrakos MDrakos marked this pull request as ready for review November 9, 2023 22:12
mitchell-as
mitchell-as approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@mitchell-as mitchell-as left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve on the condition that you run the "revert" integration tests and they pass. Yesterday the "activate" integration test failed after the error message changed and the test was not updated.

@MDrakos
Copy link
Member Author

MDrakos commented Nov 9, 2023

I approve on the condition that you run the "revert" integration tests and they pass. Yesterday the "activate" integration test failed after the error message changed and the test was not updated.

Good call!

@MDrakos MDrakos merged commit 79e7849 into version/0-42-0-RC1 Nov 9, 2023
16 checks passed
@MDrakos MDrakos deleted the DX-2319 branch November 9, 2023 22:38
as-builds added a commit that referenced this pull request Nov 9, 2023
@as-builds
Merge branch version/0-42-0-RC1 to adopt changes from PR #2875
12da63c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchell-as mitchell-as mitchell-as approved these changes

Assignees
No one assigned
Labels
Test: revert
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MDrakos @mitchell-as