Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log build expression in buildplaner requests #3111

Merged
merged 4 commits into from
Feb 20, 2024
Merged

Log build expression in buildplaner requests #3111

merged 4 commits into from
Feb 20, 2024

Conversation

MDrakos
Copy link
Member

@MDrakos MDrakos commented Feb 15, 2024 •
edited by github-actions bot
Loading

TaskDX-2483 We have an environment variable to expose the build expression

@MDrakos MDrakos changed the base branch from master to version/0-44-0-RC1 February 15, 2024 17:53
mitchell-as
mitchell-as requested changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@mitchell-as mitchell-as left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgive me if I'm missing something obvious, but wouldn't this always log stuff instead of just when an environment variable is enabled?

@MDrakos
Copy link
Member Author

MDrakos commented Feb 15, 2024

Forgive me if I'm missing something obvious, but wouldn't this always log stuff instead of just when an environment variable is enabled?

🤦‍♂️ I had this logic in an earlier iteration but for some reason removed it. Thanks for catching that.

@MDrakos MDrakos merged commit a17333e into version/0-44-0-RC1 Feb 20, 2024
7 checks passed
@MDrakos MDrakos deleted the DX-2483 branch February 20, 2024 20:49
as-builds added a commit that referenced this pull request Feb 20, 2024
@as-builds
Merge branch version/0-44-0-RC1 to adopt changes from PR #3111
2cb38cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchell-as mitchell-as mitchell-as approved these changes

Assignees
No one assigned
Labels
Test: critical
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MDrakos @mitchell-as