Added partial version detection for state install.
#3190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to `state init`.
|
Test failure is one of the usual timeouts and not caused by this PR. |
MDrakos
approved these changes
Mar 22, 2024
| @@ -218,6 +222,18 @@ func (r *RequirementOperation) ExecuteRequirementOperation( | |||
|
|
|||
| requirementName = normalized | |||
|
|
|||
| // If a bare version number was given, and if it is a partial version number (e.g. requests@2), | |||
| // we'll want to ultimately append a '.x' suffix. | |||
| if versionRe.MatchString(requirementVersion) { | |||
There was a problem hiding this comment.
nit: Any appetite to centralizing this logic that is shared between init and install now?
There was a problem hiding this comment.
No, they don't actually share much of the same code. One queries for a language, the other for a package/bundle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to
state init.