Correctly save to activestate.yaml the branch name for the given commit ID. #3206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mitchell-as
commented
Apr 1, 2024
•
mitchell-as
commented
 DX-2658 Activate by commitID from different then main branch saved incorrectly in as.yaml file
|
mitchell-as
changed the title
mitchell-as
force-pushed
the
mitchell/dx-2658
branch
from
555cdeb
to
d61e1c8
Compare
MDrakos
approved these changes
Apr 1, 2024
| // Fetch the branch the given commitID is on. | ||
| case commitID != nil: | ||
| for _, b := range pj.Branches { | ||
| if belongs, err := model.CommitBelongsToBranch(ns.Owner, ns.Project, b.Label, *commitID, r.auth); err == nil && belongs { |
There was a problem hiding this comment.
It's unfortunate the number of API calls we're going to have to make in order to determine this. I did some poking around the VCS API and didn't see anything. It may be worth asking if something exists for this use case, but I doubt it so I'll leave it up to you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.