Use errs.JoinMessage() when sending errors to Rollbar or the log.
#3267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mitchell-as
commented
Apr 29, 2024
•
mitchell-as
commented
 DX-2740 Ensure `multilog.Error()` calls use `errs.JoinMessage(err)` instead of just `err`.
|
github-actions
bot
changed the base branch from
version/0-44-0-RC1
to
version/0-45-0-RC1
mitchell-as
force-pushed
the
mitchell/dx-2740
branch
from
7b5b6dd
to
5eaab1b
Compare
mitchell-as
force-pushed
the
mitchell/dx-2740
branch
from
5eaab1b
to
f3d545b
Compare
MDrakos
requested changes
Apr 29, 2024
internal/logging/logging.go
Outdated
Comment on lines
248
to
250
| if err, ok := arg.(error); ok { | ||
| args[i] = errs.JoinMessage(err) | ||
| } |
There was a problem hiding this comment.
This switch is already a type-check, so I think it makes sense to move this to an case rather than use the default.
There was a problem hiding this comment.
You are correct. I was thinking if the error was something like a locale.WrappedError, the arg.(type) would not go into a case error. However, the debugger proved otherwise and I learned something new. Thanks for pointing this out!
MDrakos
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.