Add ExternalErrors error type #3280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchell-as
previously approved these changes
May 3, 2024
Comment on lines
+24
to
+25
| inputErr bool | ||
| externalErr bool |
There was a problem hiding this comment.
There may be a case for changing these into a single enum field if they are mutually exclusive. I'll leave it up to you though.
internal/runners/initialize/init.go
Outdated
| @@ -189,10 +189,10 @@ func (r *Initialize) Run(params *RunParams) (rerr error) { | |||
|
|
|||
| version, err := deriveVersion(lang, languageVersion, r.auth) | |||
| if err != nil { | |||
| if inferred || !locale.IsInputError(err) { | |||
| if inferred || (!locale.IsInputError(err) && !errs.IsExternalError(err)) { | |||
There was a problem hiding this comment.
This is at least the second time I've seen this. Would it make sense to add a function that would wrap this so if we were to add more types of errors, we'd only have to change that function instead of all of these instances?
There was a problem hiding this comment.
This is a good idea. Thanks for the suggestion.
| @@ -143,10 +143,10 @@ func confirmLock(prom prompt.Prompter) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func fetchExactVersion(an analytics.Dispatcher, svc *model.SvcModel, channel, version string) (string, error) { | |||
| func fetchExactVersion(svc *model.SvcModel, channel, version string) (string, error) { | |||
There was a problem hiding this comment.
Cool, thanks for catching this unused parameter and removing it!
mitchell-as
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The major changes are in
internal/errs/errs.goandinternal/locale/errors.go. The rest of the changeset it updating user input errors to external errors. I tried to catch as many as I could. The vast majority ofNewInputErrorcalls are correct so this mostly updates the wrapped errors.