State publish respects EDITOR environment variable
#3284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MDrakos
commented
May 3, 2024
•
MDrakos
commented
 DX-2768 state publish doesn't respect EDITOR env var
|
mitchell-as
requested changes
May 6, 2024
| @@ -100,92 +97,6 @@ func (suite *EditTestSuite) TestCreateScriptFile_Expand() { | |||
| suite.Equal(v, string(content)) | |||
| } | |||
|
|
|||
| func (suite *EditTestSuite) TestGetOpenCmd_EditorSet() { | |||
There was a problem hiding this comment.
Did you consider moving this test to your new package? If not, is there a way we could unit- or integration-test your new package?
There was a problem hiding this comment.
Thanks for flagging that. I meant to put them back but forgot over the weekend. Note that most of these tests aren't valid any longer as we're wrapping the open library. I've attempted to adapt them to the new implementation but they aren't the same as before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.