Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing integration test #3397

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Fix failing integration test #3397

merged 2 commits into from
Jul 17, 2024

Conversation

MDrakos
Copy link
Member

@MDrakos MDrakos commented Jul 9, 2024

BugDX-2948 Nightly failure: TestPackageIntegrationTestSuite/TestCVE_Indirect

It turns out that this is is not superfluous: #3386 (comment). The requirement name is used when summarizing CVEs to determine which CVEs are directly related to the requirement being brought in and which are from dependencies.

Also note that the test failures are known and not related to this PR.

@github-actions github-actions bot changed the base branch from master to version/0-46-0-RC1 July 9, 2024 21:33
@MDrakos MDrakos requested a review from mitchell-as July 9, 2024 21:50
@mitchell-as
Copy link
Contributor

Good catch! Sorry about that 😅

mitchell-as
mitchell-as previously approved these changes Jul 10, 2024
@MDrakos MDrakos merged commit 569f0ac into version/0-46-0-RC1 Jul 17, 2024
4 of 7 checks passed
@MDrakos MDrakos deleted the DX-2948 branch July 17, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants