Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added state export buildplan. #3398

Merged
merged 5 commits into from
Jul 18, 2024
Merged

Added state export buildplan. #3398

merged 5 commits into from
Jul 18, 2024

Conversation

mitchell-as
Copy link
Contributor

@mitchell-as mitchell-as commented Jul 15, 2024 •
edited by github-actions bot
Loading

StoryDX-2900 As a user, I want to have a command to expose the buildplan

@mitchell-as mitchell-as force-pushed the mitchell/dx-2900 branch 2 times, most recently from 22e9a9a to 84d9a23 Compare July 15, 2024 18:58
@mitchell-as mitchell-as changed the base branch from master to version/0-46-0-RC1 July 15, 2024 19:22
mitchell-as
mitchell-as commented Jul 15, 2024
View reviewed changes
internal/runbits/buildplanner/buildplanner.go
@@ -0,0 +1,173 @@
package buildplanner
Copy link
Contributor Author

@mitchell-as mitchell-as Jul 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was extracted from the artifacts runner. It was fetching a commit and returning the commit's build plan. This runbit exposes both the commit and the build plan. The logic is unchanged.

@mitchell-as mitchell-as requested a review from MDrakos July 15, 2024 22:35
@mitchell-as mitchell-as marked this pull request as ready for review July 15, 2024 22:35
MDrakos
MDrakos requested changes Jul 17, 2024
View reviewed changes
Copy link
Member

@MDrakos MDrakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just one very minor change.

cmd/state/internal/cmdtree/export.go Outdated Show resolved Hide resolved
mitchell-as and others added 2 commits July 17, 2024 14:36
@mitchell-as
Copy link
Contributor Author

Test failure is known and not related to this PR.

@mitchell-as
Copy link
Contributor Author

I applied your suggestion and fixed a merge conflict. There were no other changes.

@mitchell-as mitchell-as requested a review from MDrakos July 17, 2024 19:58
@mitchell-as mitchell-as merged commit 88c49ec into version/0-46-0-RC1 Jul 18, 2024
7 checks passed
@mitchell-as mitchell-as deleted the mitchell/dx-2900 branch July 18, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MDrakos MDrakos MDrakos approved these changes

Assignees
No one assigned
Labels
Test: artifacts Test: export
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitchell-as @MDrakos