Do not assume there is a local history when checking if a commit is within project history. #3431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mitchell-as
commented
Aug 1, 2024
•
mitchell-as
commented
 DX-2992 Nightly failure: TestArtifactsIntegrationTestSuite/TestArtifacts_Download_Remote
|
…ithin project history.
MDrakos
approved these changes
Aug 1, 2024
| @@ -888,16 +888,18 @@ func GetCommitWithinCommitHistory(currentCommitID, targetCommitID strfmt.UUID, a | |||
| // This function exists primarily as an existence check because the buildplanner API currently | |||
| // accepts a query for a org/project#commitID even if commitID does not belong to org/project. | |||
| // See DS-1705 (yes, DS, not DX). | |||
| func GetCommitWithinProjectHistory(commitID strfmt.UUID, owner, name string, localCommitID strfmt.UUID, auth *authentication.Auth) (*mono_models.Commit, error) { | |||
| func GetCommitWithinProjectHistory(commitID strfmt.UUID, owner, name string, localCommitID *strfmt.UUID, auth *authentication.Auth) (*mono_models.Commit, error) { | |||
There was a problem hiding this comment.
nit: We may want to consider renaming commitID to searchCommitID as it is hard to determine what the difference in commitID and localCommitID are. In fact, for the state export buildplan use-case I believe these two commit IDs will be the same, which further adds to the confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.