Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various minor fixes #856

Merged
merged 6 commits into from
Apr 23, 2024
Merged

Various minor fixes #856

merged 6 commits into from
Apr 23, 2024

Conversation

jpn--
Copy link
Member

@jpn-- jpn-- commented Apr 22, 2024 •
edited
Loading

  • Remove duplicate JointTourFrequencyCompositionSettings. Previous work accidentally created two slightly different versions of JointTourFrequencyCompositionSettings. This PR removes one of the two and just uses one version in all places where it is expected.
  • Add global constants to some models from which they were missing: parking location and trip destination.
  • Include constants in sharrow tracing and test recovery (when sharrow and legacy code results don't match)

@jpn-- jpn-- changed the title Remove duplicate JointTourFrequencyCompositionSettings Various minor fixes Apr 22, 2024
@jpn-- jpn-- merged commit 4085bfc into ActivitySim:main Apr 23, 2024
17 checks passed
@jpn-- jpn-- deleted the joint-tour-dupe-settings branch April 23, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jpn--