Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser activity missing for firefox #120

Closed
vesatoivonen opened this issue Jan 18, 2019 · 9 comments
Closed

Browser activity missing for firefox #120

vesatoivonen opened this issue Jan 18, 2019 · 9 comments

Comments

@vesatoivonen
Copy link

I'm on version v0.8.0b7 and using aw-watcher-web-chrome and aw-watcher-web-firefox.
Firefox bucket is always empty on activity tab, but on timeline I can see that firefox data is collected.
Chrome's data is shown propery on both views.

screenshot_2019-01-18_11-09-34
screenshot_2019-01-18_11-10-22

@vesatoivonen
Copy link
Author

I poked around a bit and it seems that this happens because I'm using Firefox Nightly and the filters used in the query don't match it.
Adding FirefoxNightly to browser_appnames on queries.js should fix this, at least for me.

@johan-bjareholt
Copy link
Member

For the web activity to be visible we also need aw-watcher-afk and aw-watcher-window to run at the same time. I can see in your timeline that aw-watcher-afk is working well (you have afk and not-afk events) but it seems like aw-watcher-window has not created any events in the timeline?
aw-watcher-window is needed so aw-server can know when the browser window is focused and not.

@johan-bjareholt
Copy link
Member

@vesatoivonen Well, that is also certainly a reason why it's not working!
Will you do a PR or should I add it to aw-webui?

@vesatoivonen
Copy link
Author

vesatoivonen commented Jan 18, 2019

It would be great if you could add it, I'm not familiar enough with the project yet.
I confirmed by curling that the appname giving at least some results for me is FirefoxNightly.
On mac and windows this might be something else.

@johan-bjareholt
Copy link
Member

Are you sure that the appname is exactly "FirefoxNightly"? No spaces or anything?
The other appnames we have seem to have spaces so I assume that this one might aswell, but it could also be a mistake on Firefox part.
These are the other appnames for firefox: ["Firefox", "Firefox.exe", "firefox", "firefox.exe", "Firefox Developer Edition", "Firefox Beta"]

@vesatoivonen
Copy link
Author

Yeah, no spaces. This is a eventmodel.datastr straight from the db: {"app": "FirefoxNightly", "title": "Preferences - Firefox Nightly"}

@ErikBjare
Copy link
Member

ErikBjare commented Jan 18, 2019

That's a bit weird though, I thought we had them nailed down in this PR: #111

Perhaps it varies between desktop environments or something? Anyway, wouldn't hurt to add.

@johan-bjareholt
Copy link
Member

johan-bjareholt commented Jan 18, 2019

@ErikBjare We have firefox beta and firefox developer edition but not firefox nightly so it makes sense.

@ErikBjare
Copy link
Member

Should have been fixed in #121, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants