Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ran eslint --fix on everything #177

Merged
merged 1 commit into from
Mar 16, 2020
Merged

Ran eslint --fix on everything #177

merged 1 commit into from
Mar 16, 2020

Conversation

ErikBjare
Copy link
Member

I noticed when creating #176 that we weren't using prettier. This fixes that.

@johan-bjareholt
Copy link
Member

Have you manually tested this?

Last time I tried running "eslint --fix" the webui was broken in a few places so I never submitted it.

@ErikBjare
Copy link
Member Author

I haven't, but I will first be merging #176 and then rerunning this and go through the entire diff before merging.

@ErikBjare
Copy link
Member Author

Merged #176 (still needs good demo data, but works), reset this branch to master, re-ran make lint-fix, and everything seems to be working (I couldn't test web or editor activity, but nothing else was broken).

Will be going through the diff and then merge when CI passes.

@ErikBjare
Copy link
Member Author

Diff looks fine. Merging.

@ErikBjare ErikBjare merged commit f9c0b40 into master Mar 16, 2020
@ErikBjare ErikBjare deleted the dev/prettier branch March 16, 2020 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants