Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selectable activity views #190

Merged
merged 2 commits into from
Apr 26, 2020
Merged

Conversation

johan-bjareholt
Copy link
Member

@johan-bjareholt johan-bjareholt commented Apr 25, 2020

Depends on #189
Fixes #79

This makes it possible to select any of the current visualizations in the "Summary" view so it becomes more of a "Favorites" view. You simply press the gear icon in the bottom right and select the type of visualization you want.

TODO:

  • Save selection in localstorage
  • Make the sunburst view not mess up alignment
  • Make views not selectable if they are not available (browser, editor, etc)
  • Split up visualization components

Screenshot_2020-04-25 ActivityWatch

@johan-bjareholt johan-bjareholt changed the title Selectable activity views WIP: Selectable activity views Apr 25, 2020
@johan-bjareholt johan-bjareholt force-pushed the dev/selectable-activity-views branch 5 times, most recently from fc12358 to 44fd1d9 Compare April 26, 2020 14:25
@johan-bjareholt johan-bjareholt changed the title WIP: Selectable activity views Selectable activity views Apr 26, 2020
Copy link
Member

@ErikBjare ErikBjare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice, very similar to what I had in mind for #79 (something Zenobase-like). I have some ideas for how to improve this further (I think the cog-dropdowns look a bit messy when everywhere), but I'll do that myself in another PR.

@johan-bjareholt
Copy link
Member Author

I have some ideas for how to improve this further (I think the cog-dropdowns look a bit messy when everywhere), but I'll do that myself in another PR.

Yeah, they're not perfect but they're a good start and easy to implement.
I couldn't come up with a better way right now, but I'm sure there are better solutions.
It's also currently just a simple dropdown list, in the future it would be cool if we could have more advanced customization, maybe getting a modal like the event editor where you can customize things a bit more.

This solution in the grand scheme of things is definitely not perfect, but it's a good starting point to make it possible for users to have a custom dashboard.

@johan-bjareholt johan-bjareholt merged commit 353634b into master Apr 26, 2020
@johan-bjareholt johan-bjareholt deleted the dev/selectable-activity-views branch April 26, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customize activity summary
2 participants