Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep shown currentView when date or periodLength changes #314

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

ErikBjare
Copy link
Member

Reported by @NicoWeio

@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #314 (691b264) into master (8b0c635) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #314   +/-   ##
=======================================
  Coverage   16.33%   16.33%           
=======================================
  Files          24       24           
  Lines        1157     1157           
  Branches      127      127           
=======================================
  Hits          189      189           
  Misses        924      924           
  Partials       44       44           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b0c635...691b264. Read the comment docs.

@ErikBjare
Copy link
Member Author

Hah, the screenshot revealed a bug...

image

Probably the first time the screenshots revealed a bug like this :)

@ErikBjare ErikBjare force-pushed the dev/keep-currentView-when-datechange branch from 3e7a284 to 691b264 Compare January 5, 2022 16:37
@ErikBjare ErikBjare merged commit 7a5abbe into master Jan 5, 2022
@ErikBjare ErikBjare deleted the dev/keep-currentView-when-datechange branch January 5, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant