Migrate to vue-chartjs v3, chart.js v4 #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to further ease the migration to Vue 3, the decorator based component was rewritten in the normal object API.
|
Very nice, thank you! Will review and merge next week :) |
Codecov Report
@@ Coverage Diff @@
## master #341 +/- ##
=======================================
Coverage 27.62% 27.62%
=======================================
Files 26 26
Lines 1354 1354
Branches 186 186
=======================================
Hits 374 374
Misses 925 925
Partials 55 55
Continue to review full report at Codecov.
|
ErikBjare
approved these changes
Jun 8, 2022
|
All looks good now! Thanks for contributing ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to further ease the migration to Vue 3, the decorator based component was rewritten in the normal object API.
Also disable ESLint rules that conflicted into madness through eslint-config-prettier.