Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on days/weeks/months on a timeline results in a CanceledError #392

Closed
BelKed opened this issue Jan 15, 2023 · 2 comments · Fixed by #396
Closed

Clicking on days/weeks/months on a timeline results in a CanceledError #392

BelKed opened this issue Jan 15, 2023 · 2 comments · Fixed by #396

Comments

@BelKed
Copy link
Contributor

BelKed commented Jan 15, 2023

A CanceledError appears when clicking "too quickly" (clicking before the data of the selected one is fully loaded) between periods (days/weeks/months) on the timeline.

Mentioned timeline (the error is shown when clicking on those "bars"):
Screenshot

Screenshot of error(s):
Screenshot


This error was probably introduced in the latest beta release (v0.12.2b1) before (in release v0.12.1) there weren't showing any errors.


Further investigation showed that the errors were also there in v0.12.1, but they were showing only in the console:
Screenshot 2023-01-15 at 17 50 00


  • OS: macOS Monterey 12.6.1
  • Browser: Firefox Developer Edition 109.0b9 (the same problem is probably reproducible in all browsers)
  • ActivityWatch: ActivityWatch v0.12.2b1
@BelKed
Copy link
Contributor Author

BelKed commented Jan 18, 2023

I've now discovered that I can reproduce almost the same CanceledError banner on v0.12.1 when clicking on the Refresh button and then clicking on another date/week/month before the data loads.

Refresh button:
Screenshot

Banner with CanceledError:
Screenshot

Error in console:
Screenshot

@BelKed
Copy link
Contributor Author

BelKed commented Feb 4, 2023

Thanks for fixing the issue, everything seems to be working just fine now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant