Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hau feature/get event #24

Merged
merged 3 commits into from
Feb 26, 2019
Merged

Hau feature/get event #24

merged 3 commits into from
Feb 26, 2019

Conversation

hkhual
Copy link
Contributor

@hkhual hkhual commented Feb 26, 2019

Hey team, I am adding get event page to fetch remote data.

zphupro
zphupro approved these changes Feb 26, 2019
View reviewed changes
Copy link
Contributor

@zphupro zphupro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I test it on a local machine and it shows the event list! no conflict and nice work !! good job bro

bradleyshao
bradleyshao approved these changes Feb 26, 2019
View reviewed changes
Copy link
Contributor

@bradleyshao bradleyshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on local, works good

@hkhual hkhual merged commit 8a59648 into dev Feb 26, 2019
@hkhual hkhual mentioned this pull request Feb 26, 2019
Closed
@hkhual hkhual deleted the hau_feature/getEvent branch February 28, 2019 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zphupro zphupro zphupro approved these changes

@bradleyshao bradleyshao bradleyshao approved these changes

@erikNeville erikNeville Awaiting requested review from erikNeville

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hkhual @bradleyshao @zphupro