Bugfix/atr 347 dev px1050 string interpolation #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' into bugfix/ATR-347-dev-PX1050-string-interpolation
…thm with a better O-notation complexity and a correct resolution of mapped parameters that supports optional parameters and params parameter
…version of ArgumentsToParametersMapping
… to base symbol set classes
…egrated it into analyzers
…ization methods that are not string const fields
…dded support for new PX1050 scenario - report now strings passed to the localizaiton methods if they are not const fields.
…alization methods
…n for hardcoded strings
SENya1990
commented
Sep 20, 2022
| <value>Hardcoded strings are not allowed as parameters for localization methods and PXException constructors. You should use string constants from the appropriate localizable messages class.</value> | ||
| </data> | ||
| <data name="PX1050Title_NonConstFieldString" xml:space="preserve"> | ||
| <value>Strings that are not constant fields are not allowed as parameters for localization methods and PXException constructors. You should use string constants from the appropriate localizable messages class.</value> |
There was a problem hiding this comment.
@EAndrosova please review the new diagnostic message for the scenarios when string that is not a constant field is passed to the localization method or PXException constructor
dropsonic
approved these changes
Sep 20, 2022
EAndrosova
approved these changes
Sep 20, 2022
SENya1990
deleted the
bugfix/ATR-347-dev-PX1050-string-interpolation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review and merge only after #457
Changes overview: