Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/atr 708 dev px1018 false alert #485

Merged
merged 28 commits into from
Jan 10, 2023

Conversation

SENya1990
Copy link
Contributor

@SENya1990 SENya1990 commented Jan 9, 2023

Merge after #484

Overview:

  • added logic to not check with PX1018 graphs if they are abstract or their primary DACs are generic type parameters
  • added unit tests to check these cases
  • fixed bug in the common helper that checks if type symbol implements an interface symbol
  • refactoring, nullable ref types annotation

…ry allocations on iterators for a frequent case of non overriden properties and methods
…return of the original method symbol that starts the overrides chain
…n - several overrides of Initialize methods weren't supported + updated unit test for the fixed bug
@dropsonic dropsonic merged commit 4db40eb into dev Jan 10, 2023
@dropsonic dropsonic deleted the bugfix/ATR-708-dev-px1018-false-alert branch January 10, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants