Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/atr 789 dev change acumatica logo #517

Merged
merged 9 commits into from
Feb 24, 2024
Merged

Bugfix/atr 789 dev change acumatica logo #517

merged 9 commits into from
Feb 24, 2024

Conversation

SENya1990
Copy link
Contributor

Merge after #516

Overview:

  • Updated Acumatica logo in all places.

@SENya1990
Copy link
Contributor Author

SENya1990 commented Feb 16, 2024 •
edited
Loading

@dropsonic maybe we should not update the logo for icons in VS menu? IMHO it looks a bit better with the old logo because it is simpler and the icon is small. Compare this:

New logo:
image

Old logo:
image

@SENya1990 SENya1990 mentioned this pull request Feb 17, 2024
Merged
dropsonic
dropsonic reviewed Feb 22, 2024
View reviewed changes
src/Acuminator/Acuminator.Analyzers/packageIcon.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original one was 256x256, the new one is not even rectangular, it is 2000x1973. Is it OK with NuGet? I suppose we should follow its recommendations.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we probably should do it. Do we need to ask the creator of the icon for the 256x256 resolution, or some online resizer will be ok?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please write to Drew Donaghy and request an icon.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Received an icon from Drew Donaghy and replaced this icon with it.

@SENya1990 SENya1990 changed the base branch from dev to master February 22, 2024 16:38
@SENya1990 SENya1990 changed the base branch from master to dev February 22, 2024 16:38
@dropsonic
Copy link
Collaborator

@dropsonic maybe we should not update the logo for icons in VS menu? IMHO it looks a bit better with the old logo because it is simpler and the icon is small. Compare this:

New logo: image

Old logo: image

Please consult with Drew on that.

@SENya1990
Copy link
Contributor Author

@dropsonic got a reply that we should use the new logo everywhere. So, we can't keep the old logo.

@dropsonic dropsonic merged commit 0ab8911 into dev Feb 24, 2024
@dropsonic dropsonic deleted the bugfix/ATR-789-dev-change-acumatica-logo branch February 24, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dropsonic dropsonic dropsonic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SENya1990 @dropsonic