Bugfix/atr 810 dev fix default navigation checks #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PK, FK and UK declarations in DACs
…ork for DACs with default navigation
…roken references in the documentation
SENya1990
commented
Jun 22, 2024
| @@ -9,7 +9,7 @@ This document describes the PX1033 diagnostic. | |||
|
|
|||
| ## Diagnostic Description | |||
| You can define a primary key field in a DAC. The diagnostic suggests adding a primary key definition to a DAC. | |||
There was a problem hiding this comment.
@EAndrosova please review the change in the diagnostic documentation
SENya1990
commented
Jun 22, 2024
| @@ -8,7 +8,8 @@ This document describes the PX1034 diagnostic. | |||
| | PX1034 | The DAC does not have an explicit foreign key declaration | Warning (ISV Level 3: Informational) | Available | | |||
|
|
|||
| ## Diagnostic Description | |||
| You can define foreign keys in a DAC. The diagnostic suggests adding a foreign key definition to a DAC. The warning is shown only for DACs that have the `PXCacheName` or `PXPrimaryGraph` attribute. | |||
| You can define foreign keys in a DAC. The diagnostic suggests adding a foreign key definition to a DAC. | |||
There was a problem hiding this comment.
@EAndrosova please review the change in the diagnostic documentation
SENya1990
commented
Jun 22, 2024
docs/diagnostics/PX1036.md
Outdated
| @@ -9,7 +9,7 @@ This document describes the PX1036 diagnostic. | |||
|
|
|||
| ## Diagnostic Description | |||
| The diagnostic checks the correct naming of primary, foreign, and unique key field declarations in DACs. For a primary key, the name should be `PK`. For a foreign key, the name can be arbitrary but the key should be declared in a public static class called `FK`. For a single unique key, the name should be `UK`. Multiple unique keys in the DAC can have arbitrary names but they must be declared in a public static class called `UK`. | |||
| The warning is shown only for DACs that have the `PXCacheName` or `PXPrimaryGraph` attribute. | |||
| The warning is shown only for DACs that have an attribute derived from the `PXCacheName` attribute, or an attribute derived from the `PXPrimaryGraphBase` attribute like `PXPrimaryGraphAttribute`. | |||
There was a problem hiding this comment.
@EAndrosova please review the change in the diagnostic documentation
dropsonic
approved these changes
Jun 24, 2024
EAndrosova
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
PXPrimaryGraphBaseAttribute