Time - Emily #43
Open
Time - Emily #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le palindrome methods.
CheezItMan
reviewed
Apr 24, 2020
There was a problem hiding this comment.
Overall nice work, you hit the learning goals here. I'm glad you could get this in. These types of questions are very common in interviews. Take a look at my inline comments and let me know what questions you have. Mostly my comments involve simplifying code.
| @@ -1,3 +1,20 @@ | |||
| def intersection(list1, list2) | |||
Comment on lines
+16
to
+20
| if duplicate_letters.values.sum == string_array.length || duplicate_letters.values.sum == string_array.length - 1 | ||
| return true | ||
| else | ||
| return false | ||
| end |
There was a problem hiding this comment.
You can simplify this and eliminate the if statement, since you're looking for a true/false answer.
Suggested change
| if duplicate_letters.values.sum == string_array.length || duplicate_letters.values.sum == string_array.length - 1 | |
| return true | |
| else | |
| return false | |
| end | |
| return duplicate_letters.values.sum == string_array.length || duplicate_letters.values.sum == string_array.length - 1 |
Comment on lines
+16
to
+18
| if intersections[value] | ||
| intersections[value] += 1 | ||
| end |
There was a problem hiding this comment.
What if the value isn't in intersections? Why not return false, if it's not there.
I would also suggest subtracting instead of adding, and then you can check to see if all the values are 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.