Space - Shonda #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Sep 29, 2020
| @@ -6,7 +6,7 @@ Congratulations! You're submitting your assignment! | |||
|
|
|||
| Question | Answer | |||
| :------------- | :------------- | |||
| How is a Heap different from a Binary Search Tree? | | |||
| How is a Heap different from a Binary Search Tree? | heaps can be ordered by max and min and for | |||
There was a problem hiding this comment.
No other answers for comprehension questions?
Comment on lines
3
to
6
| // This method uses a heap to sort an array. | ||
| // Time Complexity: ? | ||
| // Space Complexity: ? | ||
| function heapsort(list) { |
Comment on lines
+14
to
+16
| // Time Complexity: O(n) | ||
| // Space Complexity: O(1) | ||
| add(key, value = key) { |
There was a problem hiding this comment.
👍 , This works, but the time complexity is O(log n)
Comment on lines
+109
to
+117
| heap = new MinHeap() | ||
| heap.add(6, 'Pasta'); | ||
| heap.add(12, 'Soup'); | ||
| heap.add(20, 'Pizza'); | ||
| heap.add(25, 'Donuts'); | ||
| heap.add(13, 'Cookies'); | ||
|
|
||
| console.log(heap.remove()) | ||
|
|
There was a problem hiding this comment.
Suggested change
| heap = new MinHeap() | |
| heap.add(6, 'Pasta'); | |
| heap.add(12, 'Soup'); | |
| heap.add(20, 'Pizza'); | |
| heap.add(25, 'Donuts'); | |
| heap.add(13, 'Cookies'); | |
| console.log(heap.remove()) |
Comment on lines
+87
to
89
| // Time complexity: O(n) | ||
| // Space complexity: O(1) | ||
| heapUp(index) { |
There was a problem hiding this comment.
This method has a time complexity of O(1), and it's really more of a swap with parent method.
Comment on lines
+78
to
80
| // Time complexity: O(1) | ||
| // Space complexity: O(1) | ||
| isEmpty() { |
Comment on lines
+37
to
+38
| let last = this.store.pop() | ||
| this.store.unshift(last) |
There was a problem hiding this comment.
This unshift is an O(n) operation, but all you really need to do is:
- Swap the 1st and last element
- Pop the last element (to return later).
Then you can heap_down as an O(log n) operation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heaps Practice
Congratulations! You're submitting your assignment!
Comprehension Questions
heap_up&heap_downmethods useful? Why?