Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swagrid/master #15

Open
wants to merge 337 commits into
base: swagrid/master
Choose a base branch
from

Conversation

yourFriendWes
Copy link

No description provided.

brittanykohler and others added 30 commits December 9, 2015 22:41
…ting in commented out code for orders controller spec
end
end

# This method will let an admin cancel an order, but we don't have

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good that you guys want to show that you attempted something, but generally shouldn't leave this in. However, if your instructors have been cool with you guys doing it like this then don't mind me.

@knguyen0710
Copy link

Visually, your site was very pleasing and navigationally intuitive. Love the attention to detail for difference between form incrementation between price and quantity. I did find that there was a small "updating" bug for your order confirmation after entering your shipping address. If you got bored, a future iteration could address this and validate the address. Other than that, awesome job!

@@ -0,0 +1 @@
2.2.3

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, this might be seem small, but this is such good practice! I once had Heroku blow up on me because I was using a built-in method that was in a newer version of Ruby. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants