-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swagrid/master #15
base: swagrid/master
Are you sure you want to change the base?
Swagrid/master #15
Conversation
Swagrid/cart merge
Swagrid/emily
…ting in commented out code for orders controller spec
Swagrid/login
end | ||
end | ||
|
||
# This method will let an admin cancel an order, but we don't have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good that you guys want to show that you attempted something, but generally shouldn't leave this in. However, if your instructors have been cool with you guys doing it like this then don't mind me.
Visually, your site was very pleasing and navigationally intuitive. Love the attention to detail for difference between form incrementation between price and quantity. I did find that there was a small "updating" bug for your order confirmation after entering your shipping address. If you got bored, a future iteration could address this and validate the address. Other than that, awesome job! |
@@ -0,0 +1 @@ | |||
2.2.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, this might be seem small, but this is such good practice! I once had Heroku blow up on me because I was using a built-in method that was in a newer version of Ruby. 👍
…ust be logged in to retire products
No description provided.