Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hw/master #20

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Hw/master #20

wants to merge 11 commits into from

Conversation

yourFriendWes
Copy link

Not finished debugging yet, but starting on cucumber tests for editing categories. Would like feedback on if I fixed previous PR issues correctly : )

@@ -1,13 +1,16 @@
class Admin::CategoriesController < Admin::BaseController
cache_sweeper :blog_sweeper

def index; redirect_to :action => 'new' ; end
def index
redirect_to :action => 'new' ;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you refactor this code to be more than one line, then you should no longer use semi-colons

@kariabancroft
Copy link

When you create a PR you should include a more meaningful title rather than the name of the branch

Given the blog is set up
And I am logged into the admin panel

Scenario: Successfully Add Categories

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This scenario looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants