Typo Blog: Fixing admin categories bug #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgranger
commented
Mar 29, 2016
lgranger
commented
- Bug preventing admin categories page fixed
- TDD & BDD tests for this is bug passing
added 9 commits
March 28, 2016 15:08
…dle cases of new/no id
|
Don't forget to add a meaningful PR message to the title of the PR so someone reading this knows the purpose |
| @@ -1,13 +1,14 @@ | |||
| require 'pry' | |||
|
The files in the db folder should not be included in your commits, please remove |
| And I press "Save" | ||
| Then I should see "Category was successfully saved." | ||
| And I should see "Test" | ||
| And I should have 1 category |
|
|
Great! The db files are in your gitignore, but they are still in this PR and should be removed/deleted. |
|
Unfortunately I was only talking about the db/db_test and db/db_development files you added, not all of the files in that folder. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.