Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laura Robertson -- Carets #32

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Conversation

LauraAddams
Copy link

Static Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? I accidentely nested some paragraphs within paragraphs.
Why is it important to consider and use semantic HTML? By using semantic HTML, it adds meaning which then is easier to dissect each section and adjust in the future.
How did you decide to structure your CSS? First I have general styling, then it is separated by section, then page type.
What was the most challenging piece of this assignment? Setting up a nice html base, I probably went a little too class heavy!
Describe one area that you gained more clarity on when completing this assignment General semantic HTML, it's a nice change from div, div, div, div.

@CheezItMan
Copy link

Static Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage Decent number of commits, Good messages.
Answered comprehension questions Check, I'm glad the semantic tags make things clearer, and that the validator helped.
Page fully loads Check
No broken links (regular or images) Check
Includes at least 4 pages and styling Check
HTML
Uses the high-level tags for organization: header, footer, main Well done here!
Appropriately using semantic tags: section, article, etc. Nicely done
All images include alternate text YES!
CSS
Using class and ID names in style declarations I like the organization in the CSS file. The comment add a lot of clarity and the class names make a lot of sense.
Style declarations are DRY Here yo could do some DRYing, but that's a minor quibble. You have some rules repeated multiple times. That could be DRYed by either adding a class to elements you want to style the same or using the , to group selections together.
Overall Nicely, yet simply done. I like the images for the portfolio and the CSS rollover effects. The pages are neat and easy to read. Well done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants