Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import of types #91

Closed
treiher opened this issue Nov 7, 2019 · 1 comment · Fixed by #166
Closed

Import of types #91

treiher opened this issue Nov 7, 2019 · 1 comment · Fixed by #166
Assignees

Comments

@treiher
Copy link
Collaborator

treiher commented Nov 7, 2019

It should be possible to use types of other packages. To be able to use a type the containing package should be withed. The type is referenced by Package.Type_Name.

@senier
Copy link
Member

senier commented Feb 29, 2020

As discussed offline yesterday, we should think about using a different separator for packages than for fields, e.g. a nice backslash for packages:

Package\Type.ENUM_LITERAL

While the specific separator is debatable, this would allow us to parse identifiers unambiguously. Other ideas that seem to qualify:

Package!Type.ENUM_LITERAL
Package~Type.ENUM_LITERAL
Package|Type.ENUM_LITERAL
Package^Type.ENUM_LITERAL
Package%Type.ENUM_LITERAL
Package$Type.ENUM_LITERAL
Package#Type.ENUM_LITERAL
Package@Type.ENUM_LITERAL

I currently lean towards the exclamation mark.

@treiher treiher self-assigned this Mar 2, 2020
treiher added a commit that referenced this issue Mar 9, 2020
treiher added a commit that referenced this issue Mar 9, 2020
treiher added a commit that referenced this issue Mar 9, 2020
treiher added a commit that referenced this issue Mar 9, 2020
treiher added a commit that referenced this issue Mar 10, 2020
treiher added a commit that referenced this issue Mar 10, 2020
treiher added a commit that referenced this issue Mar 10, 2020
treiher added a commit that referenced this issue Jun 2, 2020
treiher added a commit that referenced this issue Jun 2, 2020
treiher added a commit that referenced this issue Jun 2, 2020
treiher added a commit that referenced this issue Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants