Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent unintentional use of unsafe CLI options #987

Closed
treiher opened this issue Apr 12, 2022 · 0 comments · Fixed by #1177
Closed

Prevent unintentional use of unsafe CLI options #987

treiher opened this issue Apr 12, 2022 · 0 comments · Fixed by #1177
Assignees
@senier
Labels
small Effort of one person-day or less
Projects
RecordFlux 0.7

Comments

@treiher
Copy link
Collaborator

treiher commented Apr 12, 2022

The currently shown warning when using --no-verification is not very prominent and often scrolls out of view very quickly due to other output.

To make it more obvious that --no-verification is unsafe, we should make it mandatory to add the --unsafe option as well when an unsafe option is used. A clear notice should be shown in a bug box that the error might be caused by the use of unsafe options, and that the command must be re-run without unsafe options before a bug is reported.
@treiher treiher added the small Effort of one person-day or less label Apr 12, 2022
@treiher treiher added this to To do in RecordFlux 0.6 via automation Apr 12, 2022
@senier senier removed this from To do in RecordFlux 0.6 Aug 23, 2022
@senier senier added this to To do in RecordFlux Future via automation Aug 23, 2022
@senier senier removed this from Medium in RecordFlux Future Aug 30, 2022
@senier senier added this to To do in RecordFlux 0.7 via automation Aug 30, 2022
@senier senier moved this from To do to Implementation in RecordFlux 0.7 Sep 1, 2022
@senier senier self-assigned this Sep 1, 2022
senier added a commit that referenced this issue Sep 1, 2022
@senier
Require --unsafe option with --no-verification
b54b3c5 
Closes #987
@senier senier mentioned this issue Sep 1, 2022
Merged
@senier senier moved this from Implementation to Review in RecordFlux 0.7 Sep 1, 2022
senier added a commit that referenced this issue Sep 2, 2022
@senier
Require --unsafe option with --no-verification
d35bca7 
Closes #987
@senier senier closed this as completed in bcee7a7 Sep 2, 2022
RecordFlux 0.7 automation moved this from Review to Done Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@senier senier

Labels
small Effort of one person-day or less
Projects
No open projects
RecordFlux 0.7
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 987: Require --unsafe option with --no-verification AdaCore/RecordFlux
2 participants
@senier @treiher