Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 243: GNAT Studio integration #301

Merged
merged 15 commits into from
Jul 6, 2020
Merged

Issue 243: GNAT Studio integration #301

merged 15 commits into from
Jul 6, 2020

Conversation

senier
Copy link
Member

@senier senier commented Jun 26, 2020

GNAT Studio integration for RecordFlux.

You can install it with (this will install the plugin into the GNAT Studio plugin directory in your home directory):

$ make install_gnatstudio

Close #243

@senier senier requested review from treiher and jklmnn June 26, 2020 06:02
@codecov
Copy link

codecov bot commented Jun 26, 2020

Codecov Report

Merging #301 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #301   +/-   ##
========================================
  Coverage    97.83%   97.83%           
========================================
  Files           25       25           
  Lines         4395     4395           
  Branches       725      725           
========================================
  Hits          4300     4300           
  Misses          57       57           
  Partials        38       38           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab383cb...1f34f44. Read the comment docs.

@treiher
Copy link
Collaborator

treiher commented Jun 26, 2020

The plugin does not work with recent versions of GNAT Studio Pro:

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/tr/.gnatstudio/plug-ins/recordflux.py", line 10, in <module>
    from gs_utils import hook
ImportError: No module named gs_utils

The following versions seem to be affected:

  • GNAT Studio 20.0 (20191009) hosted on x86_64-pc-linux-gnu
  • GNAT Studio 20.1 (20200107) hosted on x86_64-pc-linux-gnu

ide/gnatstudio/recordflux.py Show resolved Hide resolved
ide/gnatstudio/recordflux.py Outdated Show resolved Hide resolved
tests/ide/recordflux.gpr Outdated Show resolved Hide resolved
@treiher treiher changed the title Issue 243 Issue 243: GNAT Studio integration Jun 26, 2020
Copy link
Member

@jklmnn jklmnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the same error with the missing gs_utils.

@senier
Copy link
Member Author

senier commented Jun 26, 2020

The following versions seem to be affected:

* GNAT Studio 20.0 (20191009) hosted on x86_64-pc-linux-gnu

* GNAT Studio 20.1 (20200107) hosted on x86_64-pc-linux-gnu

You can try the most recent commit for a fix.

@treiher
Copy link
Collaborator

treiher commented Jun 26, 2020

You can try the most recent commit for a fix.

This fixed the issue for me.

jklmnn
jklmnn previously approved these changes Jun 26, 2020
jklmnn
jklmnn previously approved these changes Jun 26, 2020
jklmnn
jklmnn previously approved these changes Jun 27, 2020
tests/ide/recordflux.gpr Show resolved Hide resolved
treiher
treiher previously approved these changes Jul 6, 2020
jklmnn
jklmnn previously approved these changes Jul 6, 2020
Alexander Senier added 7 commits July 6, 2020 10:34
A menu is created to check a single file, check all RecordFlux files,
generate code for a single file, generate code for all RecordFlux files.

FIXME: Files are generated into Object_Dir (cannot be compiled)
FIXME: Adding new spec from context menu does not work

Ref. #243
Pylint and mypy cannot be used as this is Python 2.7 code
@senier
Copy link
Member Author

senier commented Jul 6, 2020

Rebased to develop.

@senier senier requested review from jklmnn and treiher July 6, 2020 08:35
@senier senier merged commit 0fefa3c into develop Jul 6, 2020
@senier senier deleted the issue_243 branch July 6, 2020 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GNAT Studio integration
3 participants