Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 328: Fix code generation and other issues #330

Merged
merged 3 commits into from
Jul 9, 2020
Merged

Conversation

treiher
Copy link
Collaborator

@treiher treiher commented Jul 8, 2020

Besides fixing #328, this will remove useless code introduced while fixing #320 and remove a duplicate, incorrectly formatted error message.

Lessons learned:

  • Always write unit tests
  • Match the complete error message, not just the beginning

Close #328

@treiher treiher requested review from senier and jklmnn July 8, 2020 17:50
@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #330 into develop will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #330      +/-   ##
===========================================
+ Coverage    97.79%   97.95%   +0.15%     
===========================================
  Files           25       25              
  Lines         4447     4447              
  Branches       747      746       -1     
===========================================
+ Hits          4349     4356       +7     
+ Misses          58       54       -4     
+ Partials        40       37       -3     
Impacted Files Coverage Δ
rflx/model.py 99.74% <ø> (-0.01%) ⬇️
rflx/generator/common.py 97.60% <100.00%> (+5.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0d3ba2...5a3c9ec. Read the comment docs.

rflx/generator/common.py Show resolved Hide resolved
tests/test_generator.py Outdated Show resolved Hide resolved
jklmnn
jklmnn previously approved these changes Jul 9, 2020
@treiher treiher merged commit 1bdb0c1 into develop Jul 9, 2020
@treiher treiher deleted the issue_328 branch July 9, 2020 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid code generation for comparison of field and aggregate
3 participants