Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 375: Fix incorrect detection of possibly empty array fields #376

Merged
merged 1 commit into from
Jul 29, 2020
Merged

Issue 375: Fix incorrect detection of possibly empty array fields #376

merged 1 commit into from
Jul 29, 2020

Conversation

treiher
Copy link
Collaborator

@treiher treiher commented Jul 29, 2020

Closes #375

@treiher treiher requested review from senier and jklmnn July 29, 2020 11:51
@senier
Copy link
Member

senier commented Jul 29, 2020

Maybe we should create a (regression) test for this issue?

jklmnn
jklmnn previously approved these changes Jul 29, 2020
View reviewed changes
@treiher
Copy link
Collaborator Author

treiher commented Jul 29, 2020

Maybe we should create a (regression) test for this issue?

You are right. I have added a test.

@treiher treiher requested a review from jklmnn July 29, 2020 13:29
@treiher treiher merged commit 023586d into develop Jul 29, 2020
@treiher treiher deleted the issue_375 branch July 29, 2020 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklmnn jklmnn jklmnn approved these changes

@senier senier senier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect detection of possibly empty array field
3 participants
@treiher @senier @jklmnn