Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 47: Extend model by protocol sessions #382

Merged
merged 127 commits into from
Aug 19, 2020
Merged

Issue 47: Extend model by protocol sessions #382

merged 127 commits into from
Aug 19, 2020

Conversation

senier
Copy link
Member

@senier senier commented Aug 1, 2020 •
edited by treiher
Loading

Close #47
Close #134
Close #135
Close #136
Close #137

  • Add state machine model (aka. sessions)
  • Support preliminary YAML syntax used in GreenTLS
  • Implement graphs for sessions

@senier senier requested review from jklmnn and treiher August 2, 2020 06:40
jklmnn
jklmnn suggested changes Aug 3, 2020
View reviewed changes
rflx/cli.py Show resolved Hide resolved
rflx/expression.py Outdated Show resolved Hide resolved
treiher
treiher requested changes Aug 11, 2020
View reviewed changes
rflx/expression.py Outdated Show resolved Hide resolved
rflx/expression.py Show resolved Hide resolved
rflx/expression.py Outdated Show resolved Hide resolved
rflx/expression.py Outdated Show resolved Hide resolved
rflx/expression.py Outdated Show resolved Hide resolved
rflx/parser/session.py Show resolved Hide resolved
rflx/parser/session.py Show resolved Hide resolved
rflx/parser/session.py Show resolved Hide resolved
rflx/expression.py Outdated Show resolved Hide resolved
rflx/session.py Outdated Show resolved Hide resolved
This was referenced Aug 11, 2020
Closed
Closed
treiher added a commit that referenced this pull request Aug 11, 2020
@treiher
Replace StateName by ID
552e1b0 
Ref. #47, #382
treiher added a commit that referenced this pull request Aug 11, 2020
@treiher
Move declarations into separate module
cb2853b 
Ref. #47, #382
treiher added a commit that referenced this pull request Aug 11, 2020
@treiher
Use abstractmethod decorator
1941b11 
Ref. #47, #382
treiher added a commit that referenced this pull request Aug 11, 2020
@treiher
Make declarations self-contained
cb1f242 
Ref. #47, #382
treiher added a commit that referenced this pull request Aug 11, 2020
@treiher
Remove unused enum literal
1c1379a 
Ref. #47, #382
treiher added a commit that referenced this pull request Aug 11, 2020
@treiher
Remove FIXME
95c9861 
Ref. #47, #382
treiher added a commit that referenced this pull request Aug 11, 2020
@treiher
Change method order
5d10721 
Ref. #47, #382
treiher added a commit that referenced this pull request Aug 11, 2020
@treiher
Replace classmethod by staticmethod
cd08374 
Ref. #47, #382
jklmnn
jklmnn suggested changes Aug 11, 2020
View reviewed changes
rflx/sessionfile.py Show resolved Hide resolved
@treiher treiher mentioned this pull request Aug 11, 2020
Closed
3 tasks
treiher added a commit that referenced this pull request Aug 11, 2020
@treiher
Move simple test yaml-file from specs into tests
fbf7c81 
Ref. #47, #382
treiher added a commit that referenced this pull request Aug 11, 2020
@treiher
Remove unnecessary immutable flag in tests
307d7a2 
Ref. #47, #382
treiher added a commit that referenced this pull request Aug 11, 2020
@treiher
Move tests into appropriate test modules
dff3baa 
Ref. #47, #382
@treiher
Copy link
Collaborator

treiher commented Aug 17, 2020

@senier Please have a look at my changes and open questions. It would be nice if you could also rebase the branch to develop. I suppose you are more confident in resolving the graph-related conflicts. I think we should only change small things on this PR, so that we can merge it soon.

treiher
treiher reviewed Aug 18, 2020
View reviewed changes
rflx/error.py Outdated Show resolved Hide resolved
@senier
Copy link
Member Author

senier commented Aug 19, 2020

@senier Please have a look at my changes and open questions. It would be nice if you could also rebase the branch to develop. I suppose you are more confident in resolving the graph-related conflicts. I think we should only change small things on this PR, so that we can merge it soon.

Done.

@treiher treiher requested a review from jklmnn August 19, 2020 08:30
@treiher treiher merged commit 02d9feb into develop Aug 19, 2020
@treiher treiher deleted the issue_47 branch August 19, 2020 11:39
treiher added a commit that referenced this pull request Aug 19, 2020
@treiher
Replace StateName by ID
176a6e9 
Ref. #47, #382
treiher added a commit that referenced this pull request Aug 19, 2020
@treiher
Move declarations into separate module
67e5cb5 
Ref. #47, #382
treiher added a commit that referenced this pull request Aug 19, 2020
@treiher
Use abstractmethod decorator
c2f7673 
Ref. #47, #382
treiher added a commit that referenced this pull request Aug 19, 2020
@treiher
Make declarations self-contained
1cb0e16 
Ref. #47, #382
treiher added a commit that referenced this pull request Aug 19, 2020
@treiher
Remove unused enum literal
634a081 
Ref. #47, #382
treiher added a commit that referenced this pull request Aug 19, 2020
@treiher
Remove FIXME
9e955e2 
Ref. #47, #382
treiher added a commit that referenced this pull request Aug 19, 2020
@treiher
Change method order
45d0662 
Ref. #47, #382
treiher added a commit that referenced this pull request Aug 19, 2020
@treiher
Replace classmethod by staticmethod
ae0a0b4 
Ref. #47, #382
treiher added a commit that referenced this pull request Aug 19, 2020
@treiher
Move simple test yaml-file from specs into tests
d568207 
Ref. #47, #382
treiher added a commit that referenced this pull request Aug 19, 2020
@treiher
Remove unnecessary immutable flag in tests
debc8e9 
Ref. #47, #382
treiher added a commit that referenced this pull request Aug 19, 2020
@treiher
Move tests into appropriate test modules
13dbcff 
Ref. #47, #382
treiher pushed a commit that referenced this pull request Aug 19, 2020
@treiher
Omit local enablePackrat() call
97bee7f 
Ref. #382
treiher pushed a commit that referenced this pull request Aug 19, 2020
@treiher
Restore order of variables in QuantifiedExpression
691ebfc 
Ref. #382
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treiher treiher treiher approved these changes

@jklmnn jklmnn jklmnn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@senier @treiher @jklmnn