Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 410: Only merge satifiable final conditions #411

Merged
merged 4 commits into from
Aug 25, 2020
Merged

Conversation

senier
Copy link
Member

@senier senier commented Aug 20, 2020

Ref. #410

@senier senier requested review from treiher and jklmnn August 20, 2020 21:26
@senier senier marked this pull request as draft August 20, 2020 21:36
rflx/model.py Outdated Show resolved Hide resolved
@senier senier force-pushed the issue_410 branch 2 times, most recently from d83631f to edb8cbc Compare August 23, 2020 14:32
@senier senier marked this pull request as ready for review August 23, 2020 14:33
@senier
Copy link
Member Author

senier commented Aug 23, 2020

Reworked handling of conditions in merged messages. Data types and whole path condition are now used properly. The merged message is now filtered for dangling states, as they may become unreachable by additional constraints (which would then be detected when constructing the message).

@senier senier requested a review from treiher August 23, 2020 14:36
@treiher
Copy link
Collaborator

treiher commented Aug 23, 2020

I have not yet looked at the changes, but I found an issue when I tried to check a specification. Z3 seems to run forever when checking the following specification (I stopped after running it about 3 minutes on lab):

package Test is

   type M1 is
      message
         F1 : Boolean
            then F2
               if F1 = True
            then null
               if F1 = False;
         F2 : Boolean
            then null
               if F2 = True;
      end message;

   type M2 is
      message
         F3 : M1
            then null
               if F3_F1 = True and F3_F2 = False;
      end message;

end Test;

@senier
Copy link
Member Author

senier commented Aug 24, 2020

I have not yet looked at the changes, but I found an issue when I tried to check a specification. Z3 seems to run forever when checking the following specification (I stopped after running it about 3 minutes on lab):

Good catch! It's not actually a Z3 issue, but as your resulting message is empty (you outer constraint contradicts with all paths and thus all fields get pruned) the substitution algorithm is stuck in an infinite loop. Of cause we need to detect this and throw an error. Fixed in be6644e.

rflx/model.py Outdated Show resolved Hide resolved
@senier senier linked an issue Aug 24, 2020 that may be closed by this pull request
jklmnn
jklmnn previously approved these changes Aug 24, 2020
rflx/model.py Outdated Show resolved Hide resolved
rflx/model.py Show resolved Hide resolved
jklmnn
jklmnn previously approved these changes Aug 24, 2020
rflx/model.py Outdated Show resolved Hide resolved
@senier senier merged commit 8ee7043 into develop Aug 25, 2020
@senier senier deleted the issue_410 branch August 25, 2020 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unaccessible conditional fields in message types
3 participants