Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 796: Add function for getting current state of session #798

Merged
merged 3 commits into from
Oct 7, 2021

Conversation

treiher
Copy link
Collaborator

@treiher treiher commented Oct 6, 2021

senier
senier previously approved these changes Oct 6, 2021
Copy link
Member

@senier senier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@treiher I wonder whether we should remove the built-in debug output from RecordFlux as printing the states can now be easily done using the Tick interface?

@treiher
Copy link
Collaborator Author

treiher commented Oct 6, 2021

Yes, that makes sense. I have created an issue for this purpose: #801.

@treiher
Copy link
Collaborator Author

treiher commented Oct 6, 2021

For some reason the verification of the DHCP Client example fails:

gnatprove -Pdhcp_client
Phase 1 of 2: generation of Global contracts ...
Phase 2 of 2: flow analysis and proof ...

rflx-dhcp_client-session.adb:190:24: medium: precondition might fail, cannot prove Field_First (Ctx, F_Parameter_Request_List) mod RFLX_Types.Byte'Size = 1, in instantiation at session.ads:7
  190 |            DHCP.Option.Set_Parameter_Request_List (RFLX_Element_Options_Ctx, Parameter_Request_List_Ctx);
      |            ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The affected code is unrelated to the changes of this PR. We have seen the same issue before:

#789 (comment)
https://github.com/Componolit/RecordFlux/runs/3762524957?check_suite_focus=true

But rerunning the jobs did not help this time.

Also, the Python ping test fails occasionally (only in the FSF GNAT job; rerunning the jobs sometimes helps here):

make -C examples/apps/ping test_python
make[1]: Entering directory '/home/runner/work/RecordFlux/RecordFlux/examples/apps/ping'
sudo -n timeout 3 `which python3` ping.py 127.0.0.1 | grep -q "64 bytes from 127.0.0.1: icmp_seq=0"
make[1]: *** [Makefile:10: test_python] Error 1
make[1]: Leaving directory '/home/runner/work/RecordFlux/RecordFlux/examples/apps/ping'
make: *** [Makefile:102: test_apps] Error 2

I cannot reproduce these issues locally.

@treiher treiher requested a review from senier October 7, 2021 11:02
@treiher treiher merged commit 8b539d7 into main Oct 7, 2021
@treiher treiher deleted the issue_796 branch October 7, 2021 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retrieve current state from session
2 participants