Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 629: Memory management #809

Merged
merged 8 commits into from
Oct 21, 2021
Merged

Issue 629: Memory management #809

merged 8 commits into from
Oct 21, 2021

Conversation

kanigsson
Copy link
Collaborator

No description provided.

@kanigsson
Copy link
Collaborator Author

@treiher There are two non-covered lines currently, I would like some guidance on how to get rid of them.

@kanigsson
Copy link
Collaborator Author

kanigsson commented Oct 14, 2021

@treiher Also, how to deal with the "test_spark" tests? They can't use the allocator, can they? Maybe the proper fix is to not delete the Free procedure.

@treiher
Copy link
Collaborator

treiher commented Oct 14, 2021

@treiher Also, how to deal with the "test_spark" tests? They can't use the allocator, can they? Maybe the proper fix is to not delete the Free procedure.

These tests are only testing messages (not sessions), so I don't see how the allocator could be used there. Are there reasons against keeping the Free procedure in RFLX_Generic_Types? An alternative would be a local instantiation of Free in the tests.

@kanigsson
Copy link
Collaborator Author

These tests are only testing messages (not sessions), so I don't see how the allocator could be used there. Are there reasons against keeping the Free procedure in RFLX_Generic_Types? An alternative would be a local instantiation of Free in the tests.

Yes, I will put the Free procedure back.

@treiher treiher changed the title Memory management Issue 629: Memory management Oct 14, 2021
@treiher treiher linked an issue Oct 14, 2021 that may be closed by this pull request
rflx/ada.py Outdated Show resolved Hide resolved
rflx/model/session.py Outdated Show resolved Hide resolved
rflx/ada.py Outdated Show resolved Hide resolved
rflx/ada.py Outdated Show resolved Hide resolved
rflx/ada.py Outdated Show resolved Hide resolved
rflx/error.py Outdated Show resolved Hide resolved
rflx/generator/allocator.py Outdated Show resolved Hide resolved
rflx/generator/generator.py Outdated Show resolved Hide resolved
rflx/generator/session.py Outdated Show resolved Hide resolved
rflx/generator/session.py Outdated Show resolved Hide resolved
rflx/generator/allocator.py Outdated Show resolved Hide resolved
tests/unit/generator_test.py Outdated Show resolved Hide resolved
@kanigsson kanigsson force-pushed the issue_629 branch 7 times, most recently from e295154 to 2b7d603 Compare October 18, 2021 09:10
@treiher
Copy link
Collaborator

treiher commented Oct 18, 2021

@kanigsson Could you please change your commits so that the update of the session and shape files is done only once in the last commit? Loading the "Files changed" page with this huge amount of changes takes very long and the many files make it hard to see the actual changes. GitHub unfortunately changed the file filter again and all files are listed even when filtered out, which doesn't help much.

rflx/ada.py Outdated Show resolved Hide resolved
rflx/generator/allocator.py Outdated Show resolved Hide resolved
rflx/error.py Outdated Show resolved Hide resolved
* more explicit argument "off" for SparkMode
* assertion instead of "fail"
* no need for allocator enum in subsystem class
tests/unit/generator_test.py Outdated Show resolved Hide resolved
@kanigsson kanigsson merged commit 47bb3ee into main Oct 21, 2021
@kanigsson kanigsson deleted the issue_629 branch October 21, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory management
2 participants