-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 629: Memory management #809
Conversation
@treiher There are two non-covered lines currently, I would like some guidance on how to get rid of them. |
@treiher Also, how to deal with the "test_spark" tests? They can't use the allocator, can they? Maybe the proper fix is to not delete the |
These tests are only testing messages (not sessions), so I don't see how the allocator could be used there. Are there reasons against keeping the |
Yes, I will put the |
28c7b75
to
5cb01ab
Compare
e295154
to
2b7d603
Compare
@kanigsson Could you please change your commits so that the update of the session and shape files is done only once in the last commit? Loading the "Files changed" page with this huge amount of changes takes very long and the many files make it hard to see the actual changes. GitHub unfortunately changed the file filter again and all files are listed even when filtered out, which doesn't help much. |
script now skips the __pycache__ folder if present.
* more explicit argument "off" for SparkMode * assertion instead of "fail" * no need for allocator enum in subsystem class
No description provided.