First pass of support for completion #22

raph-amiard · 2018-11-06T20:23:50Z

Depends on AdaCore/langkit#102
and AdaCore/libadalang#164

reznikmm · 2018-11-07T08:52:32Z

It seems we need to bump stable branch of libadalang to make it working

raph-amiard · 2018-11-07T13:23:11Z

@reznikmm Ah, didn't know this relied on the stable version of LAL. I wonder if for now we shouldn't make it sync with LAL, and maybe have a stable branch for it that is in sync with LAL stable ? It would make development of new features much easier ...

reznikmm · 2018-11-08T16:47:44Z

source/ada/lsp-ada_documents.adb

@@ -33,9 +33,10 @@ package body LSP.Ada_Documents is
   function To_LSP_String
     (Value : Wide_Wide_String) return LSP.Types.LSP_String;

-   function Get_Symbol_Kind


Why do you rename this function? It returns LSP.Messages.SymbolKind; So Get_Symbol_Kind is good enough for me.

I do not only rename it, I change its mode of operation: Before it operated on an Ada_Node, now it operates on a Decl, hence the renaming. Also, as you can see in this next commit:

162c8f1

It's used as a basis to provide completion kind too. We can rename it Get_Decl_Symbol_Kind if you prefer, but ultimately it would be good to have all of those based on some function that operates on an abstract kind, in order to not duplicate the logic for every kind.

I would keep these two kinds independent, so we will be able to change mapping from nodes to symbol kind without affecting mapping to completion kind.

I disagree.

I'm not going to duplicate code today because we might need that later. If we need different logic later, we'll take care of it later, it's simple enough.

There is no practical use case where you want a different kind for symbols and completions. Also keep in mind that all those kinds determine are icons.

Also please notice that the two enum types share a lot of enum literals. If something is A_Function for completion, there is a very big chance that it will stay that way for symbols, and no reason to duplicate the mappings from LAL.

reznikmm · 2018-11-08T16:58:02Z

source/ada/lsp-ada_contexts.adb


-      Search_GPR_File (Root, Result);
+         --  If not found, perform a comprehensive search everywhere below
+         --  root. TODO: I'm not sure about that logic. As an user I might


I don't think comments in the code is right place to discuss server behavior. If you are not sure, open an issue instead of add a comment.

I agree, however a comment is better than nothing in the meantime ! I added a comment because I needed to understand what this function did.

I opened an issue and a reference to the issue in the comment. I prefer to keep the comment so we don't forget about it later :)

So, we have the issue and we won't forget it. Part after TODO: is not required any more.

Again, I disagree! It might not be apparent to somebody reading/modifying this code that there is something going on here that might need to be changed, and the information might be useful to her/him. Or, as @setton put it, there is very rarely too much comments. But whatever, will remove it, it's unimportant enough.

reznikmm · 2018-11-08T17:04:18Z

source/ada/lsp-ada_driver.adb

+            Server_Trace.Trace (Symbolic_Traceback (E));
+
+         when Ada.IO_Exceptions.End_Error =>
+            Server_Trace.Trace


I would prefer Failure exit status here. One of the test in our tiny testsuite checks this.

You mean rather than checking for End_Error ? This was the shortest path, I modified the function that raised a Constraint_Error before. We can further modify it to use error codes instead, but I would suggest doing that in a second pass, since this code is already an improvement over the status quo.

Ah ok, I think I understood what you meant. You want the server to quit with an error code on this condition right ? In that case: OK, will take care of it !

FWIW: VS Code always quit like that on my system for some reason, which is why I didn't assume that it was an error case ...

WIP:

The LSP shouldn't create project files implicitly for the user inside his project directory. Leave that responsibility to the LSP clients, but provide a sane default behavior using a default project file in /tmp/.

1. Custom unit provider is not needed 2. It didn't include defensive guard against empty files. Consequently, when a unit wouldn't be found, Unit_File_Name would return the empty string, and then Get_Unit would try to parse the root dir as a file. For an obscure reason, this is not rejected by Libadalang at the moment. Replace the unit provider by Libadalang's Project_Unit_Provider.

raph-amiard force-pushed the topic/completion branch from 28334b3 to bf38af1 Compare November 6, 2018 22:32

raph-amiard force-pushed the topic/completion branch 2 times, most recently from 347eb37 to 839bc48 Compare November 8, 2018 15:09

reznikmm reviewed Nov 8, 2018

View reviewed changes

raph-amiard force-pushed the topic/completion branch from 839bc48 to 0769e0d Compare November 8, 2018 16:51

reznikmm requested changes Nov 8, 2018

View reviewed changes

raph-amiard mentioned this pull request Nov 8, 2018

Don't try to search for project file for the user #23

Closed

raph-amiard force-pushed the topic/completion branch 6 times, most recently from 1d24a52 to b99c7c9 Compare November 9, 2018 19:18

raph-amiard added 6 commits November 9, 2018 21:31

Remove -gnatyyo

e31ee4e

Get_Symbol_Kind -> Get_Decl_Kind

d9e8dfc

WIP:

Implement completion request

8e6e2d5

Add Empty_Vector constant

7134ec8

Basic traces setup

1d6397b

Fix get_completions_at + add traces

56ddc95

raph-amiard force-pushed the topic/completion branch from b99c7c9 to 6fe6b22 Compare November 9, 2018 20:37

raph-amiard added 7 commits November 9, 2018 21:39

Create default project in temp dir

96ae1d9

The LSP shouldn't create project files implicitly for the user inside his project directory. Leave that responsibility to the LSP clients, but provide a sane default behavior using a default project file in /tmp/.

Add reload primitive to Ada context type

6023cfc

Fix completion name for child units

d8f7273

Make Document.Get_Node_At error resilient

6d89619

Don't use Constraint_Error

89c6aa0

Make server's main a loop with exception handling & logging

2cc21af

First pass over README

ea99ddc

raph-amiard force-pushed the topic/completion branch from 6fe6b22 to ea99ddc Compare November 9, 2018 20:39

reznikmm approved these changes Nov 10, 2018

View reviewed changes

reznikmm merged commit 701e379 into AdaCore:master Nov 10, 2018

reznikmm mentioned this pull request Mar 22, 2019

R430-030 Fix response parsing in the generic #77

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

First pass of support for completion #22

First pass of support for completion #22

raph-amiard commented Nov 6, 2018

reznikmm commented Nov 7, 2018

raph-amiard commented Nov 7, 2018

reznikmm Nov 8, 2018

raph-amiard Nov 8, 2018

reznikmm Nov 8, 2018

raph-amiard Nov 9, 2018 •

edited

Loading

reznikmm Nov 8, 2018

raph-amiard Nov 8, 2018

raph-amiard Nov 8, 2018

reznikmm Nov 8, 2018

raph-amiard Nov 9, 2018

reznikmm Nov 8, 2018

raph-amiard Nov 8, 2018 •

edited

Loading

raph-amiard Nov 8, 2018

First pass of support for completion #22

First pass of support for completion #22

Conversation

raph-amiard commented Nov 6, 2018

reznikmm commented Nov 7, 2018

raph-amiard commented Nov 7, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

raph-amiard Nov 9, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

raph-amiard Nov 8, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

raph-amiard Nov 9, 2018 •

edited

Loading

raph-amiard Nov 8, 2018 •

edited

Loading